Skip to content

Don't coalesce unless there are multiple component IDs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shsms merged 1 commit into from
Jun 24, 2025
Merged

Don't coalesce unless there are multiple component IDs #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/graph/formulas/generators/generic/coalesce.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,15 @@ impl CoalesceFormulaBuilder {
/// Generates a formula that uses the `COALESCE` function to return the first
/// non-null value from the provided component IDs.
pub fn build(self) -> Result<String, Error> {
if self.component_ids.len() == 1 {
if let Some(component_id) = self.component_ids.into_iter().next() {
return Ok(Expr::Component { component_id }.to_string());
} else {
return Err(Error::internal(
"Failed to create expression for single component ID.",
));
}
}
let expr = Expr::coalesce(
self.component_ids
.into_iter()
Expand Down Expand Up @@ -65,7 +74,7 @@ mod tests {
let formula = graph.coalesce(BTreeSet::from([1, 2]))?;
assert_eq!(formula, "COALESCE(#1, #2)");
let formula = graph.coalesce(BTreeSet::from([1]))?;
assert_eq!(formula, "COALESCE(#1)");
assert_eq!(formula, "#1");
let formula = graph.coalesce(BTreeSet::from([]));
assert_eq!(
formula,
Expand Down
Loading