Add more common operations to Quantity
#10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is safe to provide for every quantity and brings it closer to a regular `float`, which means they can be used in generic code. Signed-off-by: Leandro Lucarella <[email protected]>
This is safe to provide for every quantity and brings it closer to a regular `float`, which means they can be used in generic code. Signed-off-by: Leandro Lucarella <[email protected]>
This is safe to provide for every quantity and brings it closer to a regular `float`, which means they can be used in generic code. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
github-actions
bot
added
part:docs
|
Enabled auto-merge. |
Marenz
reviewed
Jun 21, 2024
| Returns: | ||
| This quantity. | ||
| """ | ||
| return self |
Marenz
reviewed
Jun 21, 2024
| Returns: | ||
| The rounded quantity. | ||
| """ | ||
| return self._new(round(self._base_value, ndigits)) |
Marenz
reviewed
Jun 21, 2024
| @pytest.mark.parametrize("ndigits", [0, 1, 2, 3]) | ||
| def test_round(value: float, ndigits: int) -> None: | ||
| """Test the rounding of the quantities.""" | ||
| assert round(Quantity(value), ndigits) == Quantity(round(value, ndigits)) |
Marenz
approved these changes
Jun 21, 2024
|
Oh, I guess the "stage these lines" from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was extracted from frequenz-floss/frequenz-sdk-python@fba4af6.