Make pytest treat warnings as errors
#335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is very difficult to change the options if they are shipped by repo-config, so it is better to put them in the template and leave users the flexibility to change them. Signed-off-by: Leandro Lucarella <[email protected]>
github-actions
bot
added
part:nox
llucax
force-pushed
the
pytest-Werror
branch
4 times, most recently
from
26137c8 to
671688f
Compare
Warnings are usually a sign of something that can be improved or even wrong, like tasks not being properly awaited or cancelled, so it's a good idea to treat them as errors to avoid them getting unnoticed. We still treat deprecations as warnings, as when testing with the `pytest_min` session is normal to get deprecation warnings as we are using old versions of dependencies. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
pytest-Werror
branch
from
671688f to
47b0143
Compare
Contributor
Author
|
Mmm, the deprecations are annoying. It would be good to have them as errors too normally, I guess. Not sure. It can be sometimes annoying when one is not planning to upgrade in the short term. If we wanted to not treat warnings as errors only in the But I guess for now this is the less problematic approach and it is a big improvement over the previous status quo, so we can go one step at the time. |
Marenz
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings are usually a sign of something that can be improved or even wrong, like tasks not being properly awaited or cancelled, so it's a good idea to treat them as errors to avoid them getting unnoticed.
This PR also moves
pytestoptions to thepyproject.tomlfiles, so they are easier to change and more flexible.