Fix mypy error with setuptools 7.6.8 type hints
#347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hints in 7.6.0 seems to have had some changes that now forces us to be much more pedantic when defining the `user_options` attribute in `setuptools.Command` subclasses. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
added
type:tech-debt
Contributor
Author
|
All other PRs are failing because of this. |
llucax
added
the
cmd:skip-release-notes
Contributor
Author
|
Should not be very controversial and the main branch is broken without this so I will force-merge, if there is anything to change we can change in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hints in 7.6.0 seems to have had some changes that now forces us to be much more pedantic when defining the
user_optionsattribute insetuptools.Commandsubclasses.