Skip to content

Conversation

@flora-hofmann-frequenz
Copy link
Collaborator

Quick info on how to use the new tooling.

@flora-hofmann-frequenz flora-hofmann-frequenz self-assigned this Oct 1, 2024
@flora-hofmann-frequenz flora-hofmann-frequenz requested a review from a team as a code owner October 1, 2024 11:19
@github-actions github-actions bot added the part:docs Affects the documentation label Oct 1, 2024
cwasicki
cwasicki previously approved these changes Oct 1, 2024
Copy link
Contributor

@cwasicki cwasicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just formatting looks a bit weird.

end_time=datetime.fromisoformat("2024-09-30T00:00:00"),
use_active_power=True,
resolution=10,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format of the above looks off.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved it in a bit more then one also does not have to scroll too far to the right.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I guess black would give something different but doesn't matter too much.

Signed-off-by: Flora <[email protected]>
end_time=datetime.fromisoformat("2024-09-30T00:00:00"),
use_active_power=True,
resolution=10,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I guess black would give something different but doesn't matter too much.

@flora-hofmann-frequenz flora-hofmann-frequenz added this pull request to the merge queue Oct 2, 2024
@flora-hofmann-frequenz
Copy link
Collaborator Author

black does not run on the readme as far as I know.

Merged via the queue into frequenz-floss:v0.x.x with commit 931627c Oct 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants