Change energy to use energy_consumed and energy_delivered #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwasicki
reviewed
Nov 28, 2024
| consumption = ( | ||
| sum( | ||
| m2.value - m1.value | ||
| for m1, m2 in zip(consumption_samples, consumption_samples[1:]) |
There was a problem hiding this comment.
This should check that the diff is positive, because the energy can reset in between. Same for production
There was a problem hiding this comment.
Should I use something like max(0, m2.value - m1.value) to set it to 0 in case there is a reset?
There was a problem hiding this comment.
Yes, that's an option, or add a if m2.value > m1.value in the next line (same as for the power case).
flora-hofmann-frequenz
force-pushed
the
change_delivered_consumed
branch
from
bde35b8 to
99deaf4
Compare
cwasicki
reviewed
Dec 3, 2024
RELEASE_NOTES.md
Outdated
| ## New Features | ||
|
|
||
| * Add Readme information | ||
| * Use energy_consumed and energy_delivered |
flora-hofmann-frequenz
force-pushed
the
change_delivered_consumed
branch
from
99deaf4 to
888da9a
Compare
Signed-off-by: Flora <[email protected]>
flora-hofmann-frequenz
force-pushed
the
change_delivered_consumed
branch
from
888da9a to
2ae6df7
Compare
cwasicki
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #18.