Warn when multiple *pool calls are made with the same parameters

If this is not done, the power manager will have to make decisions on
how to prioritize requests from such pools.

Signed-off-by: Sahas Subramanian <[email protected]>

Author: shsms

src/frequenz/sdk/microgrid/_data_pipeline.py

@@ -10,6 +10,7 @@
 
 from __future__ import annotations
 
+import logging
 import sys
 import typing
 from collections import abc
@@ -44,6 +45,8 @@
     from ..timeseries.logical_meter import LogicalMeter
     from ..timeseries.producer import Producer
 
+_logger = logging.getLogger(__name__)
+
 
 _REQUEST_RECV_BUFFER_SIZE = 500
 """The maximum number of requests that can be queued in the request receiver.
@@ -112,6 +115,13 @@ def __init__(
         self._frequency_instance: GridFrequency | None = None
         self._voltage_instance: VoltageStreamer | None = None
 
+        self._known_pool_keys: set[str] = set()
+        """A set of keys for corresponding to created EVChargerPool instances.
+
+        This is used to warn the user if they try to create a new EVChargerPool instance
+        for the same set of component IDs, and with the same priority.
+        """
+
     def frequency(self) -> GridFrequency:
         """Return the grid frequency measuring point."""
         if self._frequency_instance is None:
@@ -199,6 +209,21 @@ def ev_charger_pool(
         if ev_charger_ids is not None:
             ref_store_key = frozenset(ev_charger_ids)
 
+        pool_key = f"{ref_store_key}-{priority}"
+        if pool_key in self._known_pool_keys:
+            _logger.warning(
+                "An EVChargerPool instance was already created for ev_charger_ids=%s "
+                "and priority=%s using `microgrid.ev_charger_pool(...)`."
+                "\n  Hint: If the multiple instances are created from the same actor, "
+                "consider reusing the same instance."
+                "\n  Hint: If the instances are created from different actors, "
+                "consider using different priorities to distinguish them.",
+                ev_charger_ids,
+                priority,
+            )
+        else:
+            self._known_pool_keys.add(pool_key)
+
         if ref_store_key not in self._ev_charger_pool_reference_stores:
             self._ev_charger_pool_reference_stores[ref_store_key] = (
                 EVChargerPoolReferenceStore(
@@ -265,6 +290,21 @@ def battery_pool(
         if battery_ids is not None:
             ref_store_key = frozenset(battery_ids)
 
+        pool_key = f"{ref_store_key}-{priority}"
+        if pool_key in self._known_pool_keys:
+            _logger.warning(
+                "A BatteryPool instance was already created for battery_ids=%s and "
+                "priority=%s using `microgrid.battery_pool(...)`."
+                "\n  Hint: If the multiple instances are created from the same actor, "
+                "consider reusing the same instance."
+                "\n  Hint: If the instances are created from different actors, "
+                "consider using different priorities to distinguish them.",
+                battery_ids,
+                priority,
+            )
+        else:
+            self._known_pool_keys.add(pool_key)
+
         if ref_store_key not in self._battery_pool_reference_stores:
             self._battery_pool_reference_stores[ref_store_key] = (
                 BatteryPoolReferenceStore(