Skip to content

Commit e2136d1

Browse files
committed
Use more intuitive variable names in resampler tests
With these names it is easier to identify which sample belongs to each metric. Signed-off-by: Leandro Lucarella <[email protected]>
1 parent c869167 commit e2136d1

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

tests/timeseries/test_resampling.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -133,25 +133,25 @@ def test_component_metric_group_resampler() -> None:
133133

134134
timestamp = datetime.now(timezone.utc)
135135

136-
value1 = 5.0
137-
value2 = 15.0
138-
value3 = 100.0
139-
value4 = 999.0
136+
value11 = 5.0
137+
value12 = 15.0
138+
value21 = 100.0
139+
value22 = 999.0
140140

141-
sample1 = Sample(timestamp - timedelta(seconds=0.7), value=value1)
142-
sample2 = Sample(timestamp - timedelta(seconds=0.5), value=value2)
143-
sample3 = Sample(timestamp - timedelta(seconds=5.05), value=value3)
144-
sample4 = Sample(timestamp - timedelta(seconds=0.99), value=value4)
141+
sample11 = Sample(timestamp - timedelta(seconds=0.7), value=value11)
142+
sample12 = Sample(timestamp - timedelta(seconds=0.5), value=value12)
143+
sample21 = Sample(timestamp - timedelta(seconds=5.05), value=value21)
144+
sample22 = Sample(timestamp - timedelta(seconds=0.99), value=value22)
145145

146-
resampler.add_sample(time_series_id=time_series_id_1, sample=sample1)
147-
resampler.add_sample(time_series_id=time_series_id_1, sample=sample2)
148-
resampler.add_sample(time_series_id=time_series_id_2, sample=sample3)
149-
resampler.add_sample(time_series_id=time_series_id_2, sample=sample4)
146+
resampler.add_sample(time_series_id=time_series_id_1, sample=sample11)
147+
resampler.add_sample(time_series_id=time_series_id_1, sample=sample12)
148+
resampler.add_sample(time_series_id=time_series_id_2, sample=sample21)
149+
resampler.add_sample(time_series_id=time_series_id_2, sample=sample22)
150150

151151
resampled_samples = dict(resampler.resample())
152152

153153
assert resampled_samples[time_series_id_1].timestamp >= timestamp
154-
assert resampled_samples[time_series_id_1].value == sum([value1, value2])
154+
assert resampled_samples[time_series_id_1].value == sum([value11, value12])
155155

156156
assert resampled_samples[time_series_id_2].timestamp >= timestamp
157-
assert resampled_samples[time_series_id_2].value == value4
157+
assert resampled_samples[time_series_id_2].value == value22

0 commit comments

Comments
 (0)