Skip to content

Switch to the LatestValueCache from the channels package #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2024
Merged

Switch to the LatestValueCache from the channels package #1002

merged 2 commits into from
Jul 17, 2024

Conversation

@shsms
Copy link
Contributor

@shsms shsms commented Jul 11, 2024

No description provided.

@shsms shsms requested a review from a team as a code owner July 11, 2024 14:51
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) part:data-pipeline Affects the data pipeline part:actor Affects an actor ot the actors utilities (decorator, etc.) part:core Affects the SDK core components (data structures, etc.) part:microgrid Affects the interactions with the microgrid labels Jul 11, 2024
@shsms
Copy link
Contributor Author

shsms commented Jul 11, 2024

Based on #998

@shsms shsms marked this pull request as draft July 11, 2024 14:52
@shsms shsms added the cmd:skip-release-notes It is not necessary to update release notes for this PR label Jul 12, 2024
shsms added 2 commits July 16, 2024 10:48
@shsms
Switch to the LatestValueCache from the channels package
71dde0f 
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Remove internal LatestValueCache implementation
54ed0d0 
This has been moved to the channels repo, and the SDK has switched to
using that implementation instead.  So the internal one is no longer
necessary.

Signed-off-by: Sahas Subramanian <[email protected]>
@shsms shsms force-pushed the latest-value-cache-cleanup branch from 8d2d109 to 54ed0d0 Compare July 16, 2024 08:48
@shsms shsms marked this pull request as ready for review July 16, 2024 08:49
@shsms shsms added this pull request to the merge queue Jul 17, 2024
Merged via the queue into frequenz-floss:v1.x.x with commit 97da4db Jul 17, 2024
@shsms shsms deleted the latest-value-cache-cleanup branch July 17, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthias-wende-frequenz matthias-wende-frequenz matthias-wende-frequenz approved these changes

@daniel-zullo-frequenz daniel-zullo-frequenz Awaiting requested review from daniel-zullo-frequenz daniel-zullo-frequenz is a code owner automatically assigned from frequenz-floss/python-sdk-team

Assignees

No one assigned

Labels

cmd:skip-release-notes It is not necessary to update release notes for this PR part:actor Affects an actor ot the actors utilities (decorator, etc.) part:core Affects the SDK core components (data structures, etc.) part:data-pipeline Affects the data pipeline part:docs Affects the documentation part:microgrid Affects the interactions with the microgrid part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

Python SDK Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shsms @matthias-wende-frequenz