Skip to content

Conversation

@llucax
Copy link
Contributor

@llucax llucax commented Jul 22, 2024

This is not necessary anymore now that merge queues use a different branch ruleset, so we can not require DCO for the merge queue to succeed, as PRs will never be queued anyway if the DCO check didn't pass.

This is not necessary anymore now that merge queues use a different
branch ruleset, so we can not require DCO for the merge queue to
succeed, as PRs will never be queued anyway if the DCO check didn't
pass.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax requested a review from a team as a code owner July 22, 2024 08:35
@llucax llucax requested a review from shsms July 22, 2024 08:35
@github-actions github-actions bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label Jul 22, 2024
@llucax llucax self-assigned this Jul 22, 2024
@llucax llucax added this to the v1.0.0-rc800 milestone Jul 22, 2024
@llucax llucax added the type:tech-debt Improves the project without visible changes for users label Jul 22, 2024
@llucax llucax enabled auto-merge July 22, 2024 08:36
@llucax llucax added this pull request to the merge queue Jul 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 24, 2024
@llucax llucax added this pull request to the merge queue Jul 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 24, 2024
@llucax llucax added this pull request to the merge queue Jul 25, 2024
@llucax llucax removed this pull request from the merge queue due to a manual request Jul 25, 2024
@llucax
Copy link
Contributor Author

llucax commented Jul 25, 2024

OK, it seems like both protection rules for the branch and for the queue are considered by the queue, as it seems this PR is not accepted by the queue because it waits forever to get the DCO check, even when the protection rule used for the queue doesn't require the DCO check. So I guess we can't get rid of this dummy workflow even with the new protection rules.

Since each merge queue needs its own ruleset and is applied only to one branch, we could just make the general protection rule for all branches mutually exclusive with the rule for new branches, this is more work as we need one ruleset per branch, but it is actually the correct solution, as right now we don't have queues for other branches than the default branch, and we had issues in the past when old branches have a different CI that can never pass the current rules, so I think it makes sense to switch to a more fine-grained ruleset.

@llucax
Copy link
Contributor Author

llucax commented Jul 25, 2024

No, this approach doesn't work either, because we can't still have different checks for the queue and the PR itself, so dropping this PR, too bad we can't get rid of this hack anyway.

@llucax llucax closed this Jul 25, 2024
@llucax llucax added the resolution:wontfix This will not be worked on label Jul 25, 2024
@llucax llucax deleted the rm-dco-queue branch August 23, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) resolution:wontfix This will not be worked on type:tech-debt Improves the project without visible changes for users

Projects

Development

Successfully merging this pull request may close these issues.

2 participants