Implement GridReactivePowerFormula #1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ela-kotulska-frequenz
added
the
type:enhancement
ela-kotulska-frequenz
requested review from
shsms
and removed request for
a team
github-actions
bot
added
part:tests
ela-kotulska-frequenz
force-pushed
the
reactive_power
branch
from
9b07790 to
cc7c87c
Compare
ela-kotulska-frequenz
force-pushed
the
reactive_power
branch
from
cc7c87c to
bb5f3a6
Compare
The same logic will be used in GridReactivePower Signed-off-by: Elzbieta Kotulska <[email protected]>
- Reduce code duplication - Prepare for upcoming reactive power method Signed-off-by: Elzbieta Kotulska <[email protected]>
Implement new formula GridReactivePowerFormula to calculate `reactive_power`. Add new method microgrid.grid().reactive_power to stream reactive power at the grid connection point. Signed-off-by: Elzbieta Kotulska <[email protected]>
ela-kotulska-frequenz
force-pushed
the
reactive_power
branch
from
bb5f3a6 to
adb9f97
Compare
github-actions
bot
added
the
part:tooling
To import ReactivePower quantity Signed-off-by: Elzbieta Kotulska <[email protected]>
Create dedicated formulas for active and reactive power calculations Signed-off-by: Elzbieta Kotulska <[email protected]>
ela-kotulska-frequenz
force-pushed
the
reactive_power
branch
from
adb9f97 to
ef74983
Compare
shsms
reviewed
Oct 17, 2024
src/frequenz/sdk/timeseries/formula_engine/_formula_generators/_grid_power_formula.py
Outdated
Show resolved
Hide resolved
src/frequenz/sdk/timeseries/formula_engine/_formula_generators/_grid_reactive_power_formula.py
Outdated
Show resolved
Hide resolved
Use dedicated quanitity ReactivePower in GridReactivePowerFormula Signed-off-by: Elzbieta Kotulska <[email protected]>
Signed-off-by: Elzbieta Kotulska <[email protected]>
Signed-off-by: Elzbieta Kotulska <[email protected]>
Signed-off-by: Elzbieta Kotulska <[email protected]>
ela-kotulska-frequenz
force-pushed
the
reactive_power
branch
from
ef74983 to
77e10dd
Compare
shsms
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.