Use frequenz-quantities library #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ela-kotulska-frequenz
added
the
type:tech-debt
ela-kotulska-frequenz
requested review from
llucax
and removed request for
a team
github-actions
bot
added
part:docs
ela-kotulska-frequenz
force-pushed
the
quantity
branch
from
26edb5c to
015be45
Compare
llucax
reviewed
Oct 14, 2024
RELEASE_NOTES.md
Outdated
| ## Upgrading | ||
|
|
||
| <!-- Here goes notes on how to upgrade from previous versions, including deprecations and what they should be replaced with --> | ||
| - Replace `frequenz.sdk.timeseries._quantities` module with the external `frequenz.quantities` package. |
There was a problem hiding this comment.
I would not use internal module names as this is intended for end-users, and also give a link to the new library.
Suggested change
| - Replace `frequenz.sdk.timeseries._quantities` module with the external `frequenz.quantities` package. | |
| - Replace `Quantity` and its sub-classes (`Power`, `Current`, etc.) in the `frequenz.sdk.timeseries` module with the external [`frequenz-quantities`](https://pypi.org/project/frequenz-quantities/) package. Please add the new library as a dependency and adapt your imports if you are using these types. |
There was a problem hiding this comment.
Fixed
Comment on lines
37
to
40
| from frequenz.quantities import ( | ||
| Current, | ||
| Energy, | ||
| Frequency, |
There was a problem hiding this comment.
Oh, I see you are re-exporting here. I wouldn't do this, I would just go ahead and remove these from here completely (including __all__ of course).
3 tasks
Signed-off-by: Elzbieta Kotulska <[email protected]>
ela-kotulska-frequenz
force-pushed
the
quantity
branch
2 times, most recently
from
0e72bcc to
5381c39
Compare
Signed-off-by: Elzbieta Kotulska <[email protected]>
Signed-off-by: Elzbieta Kotulska <[email protected]>
Signed-off-by: Elzbieta Kotulska <[email protected]>
Signed-off-by: Elzbieta Kotulska <[email protected]>
ela-kotulska-frequenz
force-pushed
the
quantity
branch
from
5381c39 to
1adeca5
Compare
Signed-off-by: Elzbieta Kotulska <[email protected]>
ela-kotulska-frequenz
force-pushed
the
quantity
branch
from
1adeca5 to
7ada5cf
Compare
shsms
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove current quantities definition