config: Allow reading from multiple files #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file was moved from the `actor` package to the `config` package, but the tests location wasn't updated. This commit brings the test location in sync with the code location again. Signed-off-by: Leandro Lucarella <[email protected]>
github-actions
bot
added
part:docs
Marenz
reviewed
Oct 24, 2024
Marenz
reviewed
Oct 24, 2024
Marenz
reviewed
Oct 24, 2024
Marenz
reviewed
Oct 24, 2024
| """ | ||
| await self.send_config() | ||
|
|
||
| parent_paths = {p.parent for p in self._config_paths} |
There was a problem hiding this comment.
unique_parent_paths = [..] for more clarity? :)
There was a problem hiding this comment.
I don't know, it is a set; is it really necessary to say that items in a set are unique?
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Marenz
reviewed
Oct 24, 2024
Marenz
reviewed
Oct 24, 2024
Marenz
reviewed
Oct 24, 2024
llucax
force-pushed
the
config-mutiple-files
branch
from
ba0ce39 to
743bbaf
Compare
cwasicki
reviewed
Oct 24, 2024
llucax
force-pushed
the
config-mutiple-files
branch
from
743bbaf to
5cd4b40
Compare
|
Enabled auto-merge. |
The `ConfigManagingActor` can now take more than one config file, and will read multiple files one after the other, overriding the previous values. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
config-mutiple-files
branch
from
c795bbf to
c0f9fd5
Compare
cwasicki
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConfigManagingActorcan now take more than one config file, and will read multiple files one after the other, overriding the previous values.Fixes #65.