Skip to content

Check that load_config raises ValidationError if config is None #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2024
Merged

Check that load_config raises ValidationError if config is None #1102

merged 1 commit into from
Nov 15, 2024

Conversation

@ela-kotulska-frequenz
Copy link
Contributor

No description provided.

@ela-kotulska-frequenz ela-kotulska-frequenz added part:tests Affects the unit, integration and performance (benchmarks) tests cmd:skip-release-notes It is not necessary to update release notes for this PR labels Nov 15, 2024
@ela-kotulska-frequenz ela-kotulska-frequenz self-assigned this Nov 15, 2024
@ela-kotulska-frequenz ela-kotulska-frequenz requested a review from a team as a code owner November 15, 2024 09:53
llucax
llucax approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm working a revamped config manager that will handle all of this. I think I will create a draft PR so you can have a look and see what's coming.

@ela-kotulska-frequenz ela-kotulska-frequenz added this pull request to the merge queue Nov 15, 2024
Merged via the queue into frequenz-floss:v1.x.x with commit 47adc26 Nov 15, 2024
20 checks passed
@ela-kotulska-frequenz ela-kotulska-frequenz deleted the config_test branch November 15, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llucax llucax llucax approved these changes

@daniel-zullo-frequenz daniel-zullo-frequenz Awaiting requested review from daniel-zullo-frequenz

Assignees

@ela-kotulska-frequenz ela-kotulska-frequenz

Labels

cmd:skip-release-notes It is not necessary to update release notes for this PR part:tests Affects the unit, integration and performance (benchmarks) tests

Projects

Python SDK Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ela-kotulska-frequenz @llucax