Fix ConfigLoggingUpdater not changing root logging level #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ela-kotulska-frequenz
added
type:bug
llucax
previously approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Interesting.
This function does nothing if the root logger already has handlers configured, unless the keyword argument force is set to True.
https://docs.python.org/3/library/logging.html#logging.basicConfig
So the format and date format will also not be affected if someone called basicConfig before the actor is instantiated. Maybe we should document this behaviour.
ela-kotulska-frequenz
force-pushed
the
logging
branch
from
86b714f to
4937680
Compare
Good idea. Documentation added |
ela-kotulska-frequenz
force-pushed
the
logging
branch
from
4937680 to
184d5ab
Compare
Setting log level with method `logging.basicConfig` during runtime is not working. Instead logging.getLogger() is used. Signed-off-by: Elzbieta Kotulska <[email protected]>
ela-kotulska-frequenz
force-pushed
the
logging
branch
from
184d5ab to
dcdc999
Compare
llucax
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting log level for root logger with method
logging.basicConfigduring runtime is not working. Instead logging.getLogger() is used.