Small debugging enhancements #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marenz
requested review from
daniel-zullo-frequenz
and removed request for
a team
github-actions
bot
added
part:docs
Marenz
force-pushed
the
little
branch
2 times, most recently
from
20b0e3d to
94d72a8
Compare
llucax
reviewed
Nov 27, 2024
Comment on lines
457
to
459
| request_receiver=channel.new_receiver( | ||
| limit=_REQUEST_RECV_BUFFER_SIZE, name=channel.name + " Receiver" | ||
| ), |
There was a problem hiding this comment.
Wait! This shouldn't be necessary. Maybe you are using name directly? If you use str(receiver) or repr(receiver) the channel name (and the word "receiver") will be already used:
- https://github.com/frequenz-floss/frequenz-channels-python/blob/b3c98e594310edde687bde4d9b39f4ac370ed676/src/frequenz/channels/_broadcast.py#L472-L483
- https://github.com/frequenz-floss/frequenz-channels-python/blob/b3c98e594310edde687bde4d9b39f4ac370ed676/src/frequenz/channels/_broadcast.py#L291-L303
There was a problem hiding this comment.
I was using .name directly, yes
src/frequenz/sdk/microgrid/_data_sourcing/microgrid_api_source.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
Easier to read & compare, especially when debugging. Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
Marenz
force-pushed
the
little
branch
2 times, most recently
from
5a4e391 to
80197eb
Compare
llucax
previously approved these changes
Nov 28, 2024
| minimum_relevant_timestamp: Minimum timestamp that was requested | ||
| timestamp: Timestamp that was requested | ||
| """ | ||
| if not _logger.isEnabledFor(logging.DEBUG): |
There was a problem hiding this comment.
This should be WARNING!
Suggested change
| if not _logger.isEnabledFor(logging.DEBUG): | |
| if not _logger.isEnabledFor(logging.WARNING): |
There was a problem hiding this comment.
Shit. So much for my FCR deployment.
Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample