Improve the logging config actor #1127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
|
Ready for review, but based on #1126. |
|
Also in preparation for a major revamp of the |
llucax
added
type:enhancement
llucax
force-pushed
the
logging-actor
branch
2 times, most recently
from
4116cf0 to
229fc95
Compare
Signed-off-by: Leandro Lucarella <[email protected]>
llucax
requested review from
Marenz and
ela-kotulska-frequenz
and removed request for
a team
|
Ready for review and merging. |
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
This is just in case the parent class calls some abstract method that is implemented in the current class, in which case it could try to accesss the attributes that are not initialized yet. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
We now have `frequenz.sdk.config.load_config()` for this. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
We are not using the `.Schema` attribute from marshmallow_dataclass, so it is better to just stick to the standard `dataclass` decorator to make thing simpler. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
When `dataclass` field have a default value, they are not required already, so the `required` field in the `metadata` is unnecessary. Signed-off-by: Leandro Lucarella <[email protected]>
RELEASE_NOTES.md
Outdated
| * The `load()` method was removed. Please use `frequenz.sdk.config.load_config()` instead. | ||
| * The class is now a standard `dataclass` instead of a `marshmallow_dataclass`. | ||
|
|
||
| - `LoggerConfig` is not a standard `dataclass` instead of a `marshmallow_dataclass`. |
There was a problem hiding this comment.
LoggerConfigis now a standarddataclassinstead of amarshmallow_dataclass.
There was a problem hiding this comment.
Can be fixed in next PR
ela-kotulska-frequenz
approved these changes
Dec 9, 2024
|
Oh, I was just fixing it :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nameargument toLoggingConfigUpdatingActorLoggingConfigUpdatingActorconstructorLogLevelLoggingConfig.loadmethoddataclassdecorator fromdataclasses__all__