Change name of the BackgroundService to include name of the class #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes more readable. Signed-off-by: Elzbieta Kotulska <[email protected]>
ela-kotulska-frequenz
added
the
part:actor
github-actions
bot
added
part:docs
llucax
reviewed
Dec 10, 2024
There was a problem hiding this comment.
I wouldn't go for this, this will be renamed to unique_id and then it doesn't make sense to have the class name in the unique ID. If you want to get a representation of the instance, just use str(instance) (or f"{instance}" or logging.debug("%s", instance)) instead of using the name explicitly (instance.name, f"{instance.name}", etc.), that will give you the full class name + unique ID.
This change is already done in core, I just didn't have time to finish the core library and do the migration. We could also update BackgroudService for now but I don't think it is worth it if we'll need to change this once we move to using core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more readable.