Don't allow checking if None is within the bounds
#1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was never supported, a `ValueError` would be raised if `None` was passed to `__contains__`. Now we assert to make it clear that it's not allowed. In the future we should probably change `Bounds` to always allow `None` as bounds and make `_T` simply bound to `Comparable`, as supporting `None` depending on the generic type makes it very hard to provide correct type hints. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
added
the
cmd:skip-release-notes
We only need to do this when the cache directory exists, otherwise the step fails with an error. Signed-off-by: Leandro Lucarella <[email protected]>
github-actions
bot
added
the
part:tooling
|
This doesn't change behavior, we can decide if we want to change it in a separate PR, but I will merge this for now to unblock the merging of the mypy update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was never supported, a
ValueErrorwould be raised ifNonewas passed to__contains__. Now we assert to make it clear that it's not allowed.In the future we should probably change
Boundsto always allowNoneas bounds and make_Tsimply bound toComparable, as supportingNonedepending on the generic type makes it very hard to provide correct type hints.