Move default unknown=EXCLUDE to BaseConfigSchema
#1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leandro Lucarella <[email protected]>
This simplifies the code as we don't need to manipulate the `load()` arguments in the wrapper functions and also brings the default to `load_config()`. Signed-off-by: Leandro Lucarella <[email protected]>
This function also only deals with dataclasses as schemas, so that option will never work. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
requested review from
ela-kotulska-frequenz
and removed request for
a team
github-actions
bot
added
part:docs
Marenz
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the code as we don't need to manipulate the
load()arguments in the wrapper functions. It also usesBaseConfigSchemaas the default base schema inload_config().