Skip to content

Disable warn on overflow in config channel receivers #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Disable warn on overflow in config channel receivers #1152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c2c9ab
Disable warn on overflow in config channel receivers
llucax Jan 23, 2025
19c0dbd
Break circular import in _data_pipeline.py
llucax Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ dependencies = [
# changing the version
# (plugins.mkdocstrings.handlers.python.import)
"frequenz-client-microgrid >= 0.6.0, < 0.7.0",
"frequenz-channels >= 1.4.0, < 2.0.0",
"frequenz-channels >= 1.6.0, < 2.0.0",
"frequenz-quantities[marshmallow] >= 1.0.0, < 2.0.0",
"networkx >= 2.8, < 4",
"numpy >= 1.26.4, < 2",
Expand All @@ -48,7 +48,7 @@ email = "[email protected]"
dev-flake8 = [
"flake8 == 7.1.1",
"flake8-docstrings == 1.7.0",
"flake8-pyproject == 1.2.3", # For reading the flake8 config from pyproject.toml
"flake8-pyproject == 1.2.3", # For reading the flake8 config from pyproject.toml
"pydoclint == 0.5.14",
"pydocstyle == 6.3.0",
]
Expand Down
6 changes: 5 additions & 1 deletion src/frequenz/sdk/config/_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,11 @@ def new_receiver( # pylint: disable=too-many-arguments
"""
_validate_load_kwargs(marshmallow_load_kwargs)

receiver = self.config_channel.new_receiver(name=f"{self}:{key}", limit=1).map(
# We disable warning on overflow, because we are only interested in the latest
# configuration, it is completely fine to drop old configuration updates.
receiver = self.config_channel.new_receiver(
name=f"{self}:{key}", limit=1, warn_on_overflow=False
).map(
lambda config: _load_config_with_logging_and_errors(
config,
config_class,
Expand Down
4 changes: 3 additions & 1 deletion src/frequenz/sdk/microgrid/_data_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
from .._internal._channels import ChannelRegistry
from ..actor._actor import Actor
from ..timeseries import ResamplerConfig
from ..timeseries._grid_frequency import GridFrequency
from ..timeseries._voltage_streamer import VoltageStreamer
from ..timeseries.grid import Grid
from ..timeseries.grid import get as get_grid
Expand All @@ -35,6 +34,7 @@
#
# pylint: disable=import-outside-toplevel
if typing.TYPE_CHECKING:
from ..timeseries._grid_frequency import GridFrequency
from ..timeseries.battery_pool import BatteryPool
from ..timeseries.battery_pool._battery_pool_reference_store import (
BatteryPoolReferenceStore,
Expand Down Expand Up @@ -140,6 +140,8 @@ def __init__(

def frequency(self) -> GridFrequency:
"""Return the grid frequency measuring point."""
from ..timeseries._grid_frequency import GridFrequency

if self._frequency_instance is None:
self._frequency_instance = GridFrequency(
self._data_sourcing_request_sender(),
Expand Down
Loading