Update numpy dependency to v2 #1160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:tooling
|
This would make it easier to support python 3.13, etc. |
|
Do we want this to be in for v1.0? |
|
That would be very nice, then we can have python 3.13 support for 1.0 |
cwasicki
requested review from
ela-kotulska-frequenz
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR updates the numpy dependency for the project to support numpy v2 by replacing the deprecated np.float_ type hints with explicit np.float64 annotations.
- Updated type annotations for numpy arrays in both core and benchmark modules
- Modified the pyproject.toml dependency specification for numpy
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/frequenz/sdk/timeseries/_periodic_feature_extractor.py | Updated numpy array type annotations from np.float_ to np.float64 |
| pyproject.toml | Updated numpy dependency to support version 2 |
| benchmarks/timeseries/periodic_feature_extractor.py | Updated numpy array type annotations from np.float_ to np.float64 |
Signed-off-by: cwasicki <[email protected]>
Signed-off-by: cwasicki <[email protected]>
llucax
approved these changes
May 6, 2025
github-project-automation
bot
moved this from To do
to Review approved
in Python SDK Roadmap
Closed
github-project-automation
bot
moved this from Review approved
to Done
in Python SDK Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of the numpy dependency to v2.x and required migration changes.