Skip to content

Don't fallback to CHPs #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Don't fallback to CHPs #1161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c2d7bf
Don't fallback to CHPs
shsms Feb 12, 2025
e58a737
Update release notes
shsms Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@
## Bug Fixes

- Fixed a bug that was preventing power proposals to go through if there once existed some proposals with overlapping component IDs, even if the old proposals have expired.

- Fixed a bug that was causing formulas to fallback to CHPs, when the CHP meters didn't have data. CHPs are not supported in the data sourcing actor and in the client, so we can't fallback to CHPs.
3 changes: 1 addition & 2 deletions src/frequenz/sdk/timeseries/formula_engine/_formula_generators/_formula_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,7 @@ def _get_meter_fallback_components(self, meter: Component) -> set[Component]:

# All fallbacks has to be of the same type and category.
if (
all(graph.is_chp(c) for c in successors)
or all(graph.is_pv_inverter(c) for c in successors)
all(graph.is_pv_inverter(c) for c in successors)
or all(graph.is_battery_inverter(c) for c in successors)
or all(graph.is_ev_charger(c) for c in successors)
):
Expand Down
Loading