Avoid creating dangling MetricFetchers
#1179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to avoid the unnecessary creation of a MetricFetcher instance when one already exists for the given key in the _metric_fetchers dictionary.
- Replaces the use of setdefault() with a get()-and-check pattern in push_metric().
- Ensures that a new MetricFetcher is only created when none is already present, preventing wasted computation.
When using `setdefault()`, if an object already existed for that key, a `MetricFetcher` will be created anyways, only to be discarded right after it was created. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
dangling-fetcher
branch
from
518c0bf to
364372d
Compare
llucax
added
type:bug
shsms
approved these changes
Mar 17, 2025
github-project-automation
bot
moved this from Review in progress
to Review approved
in Python SDK Roadmap
github-project-automation
bot
moved this from Review approved
to Done
in Python SDK Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
setdefault(), if an object already existed for that key, aMetricFetcherwill be created anyways, only to be discarded right after it was created.