Skip to content

Conversation

@llucax
Copy link
Contributor

@llucax llucax commented Apr 9, 2025

We now also treat warnings as errors, although we had to make one exception because of the clean-up issues we have in the SDK.

llucax added 6 commits April 9, 2025 11:09
We now use the new much simpler macros hooks in repo-config v0.12.

Signed-off-by: Leandro Lucarella <[email protected]>
We need to make an exception for `PytestUnraisableExceptionWarning`
because we have some cleanup issues, and sometimes exceptions are raised
in `__del__` methods, for example when trying to do async stuff and the
event loop is already closed. This could even be caused by the GC, some
time after the test function that has the issue was completed.

Signed-off-by: Leandro Lucarella <[email protected]>
This allows to get PRs that are easier to merge.

Signed-off-by: Leandro Lucarella <[email protected]>
Use the new (old?) name ci.yaml for push/merge queue/etc and do some
minor cleanup.

Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings April 9, 2025 09:59
@llucax llucax requested a review from a team as a code owner April 9, 2025 09:59
@llucax llucax requested review from daniel-zullo-frequenz and removed request for a team April 9, 2025 09:59
@llucax llucax self-assigned this Apr 9, 2025
@github-actions github-actions bot added part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels Apr 9, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

@llucax
Copy link
Contributor Author

llucax commented Apr 9, 2025

Related to:

@llucax llucax added type:tech-debt Improves the project without visible changes for users cmd:skip-release-notes It is not necessary to update release notes for this PR labels Apr 9, 2025
@llucax llucax enabled auto-merge April 9, 2025 10:01
@llucax llucax requested review from Marenz and shsms April 9, 2025 10:02
@llucax
Copy link
Contributor Author

llucax commented Apr 9, 2025

I already switched PyPI back to publish from the ci.yaml workflow, so we should merge this before releasing.

@llucax llucax moved this from To do to Review in progress in Python SDK Roadmap Apr 9, 2025
@llucax llucax added this pull request to the merge queue Apr 9, 2025
@github-project-automation github-project-automation bot moved this from Review in progress to Review approved in Python SDK Roadmap Apr 9, 2025
Merged via the queue into frequenz-floss:v1.x.x with commit d70fed2 Apr 9, 2025
7 checks passed
@llucax llucax deleted the repo-config-0.13 branch April 9, 2025 11:18
@github-project-automation github-project-automation bot moved this from Review approved to Done in Python SDK Roadmap Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmd:skip-release-notes It is not necessary to update release notes for this PR part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) type:tech-debt Improves the project without visible changes for users

Projects

Development

Successfully merging this pull request may close these issues.

2 participants