Add missing PV and EV components to datapipeline's stop method
#1222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
github-actions
bot
added
part:tests
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing EV and PV component shutdowns to the datapipeline’s stop method to ensure proper termination of all microgrid elements.
- Updates test cases in the PV Pool and EV Charger Pool to concurrently stop the datapipeline, streamer, and mock grid.
- Modifies the datapipeline _stop method to include stopping EV and PV power wrappers as well as EV charger and PV pool reference stores.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/timeseries/_pv_pool/test_pv_pool_control_methods.py | Adds concurrent stop calls in PV pool tests |
| tests/timeseries/_ev_charger_pool/test_ev_charger_pool_control_methods.py | Adds concurrent stop calls in EV charger pool tests |
| src/frequenz/sdk/microgrid/_data_pipeline.py | Updates stop method to properly stop additional EV and PV components |
shsms
added
the
cmd:skip-release-notes
shsms
force-pushed
the
📚🚰🧹(data-pipeline-cleanup)
branch
from
f4f9516 to
919a0f4
Compare
llucax
reviewed
May 20, 2025
tests/timeseries/_ev_charger_pool/test_ev_charger_pool_control_methods.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Sahas Subramanian <[email protected]>
llucax
approved these changes
May 20, 2025
github-project-automation
bot
moved this from To do
to Review approved
in Python SDK Roadmap
github-project-automation
bot
moved this from Review approved
to Done
in Python SDK Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.