Skip to content

Update microgrid client #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Update microgrid client #1230

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3de905
Update microgrid client to v0.9.0
Marenz Jun 11, 2025
45c4ad7
BackgroundService: Remove __del__ method
Marenz Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/frequenz/sdk/actor/_background_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,13 +268,6 @@ def __await__(self) -> collections.abc.Generator[None, None, None]:
"""
return self.wait().__await__()

def __del__(self) -> None:
"""Destroy this instance.

Cancel all running tasks spawned by this background service.
"""
self.cancel("{self!r} was deleted")

Comment on lines -271 to -277
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the fix is to check if the event loop is running before calling cancel, because when the loop is there, we still want to cancel and cleanup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but I don't think we gain much from that tbh. Cleanup should not rely on del

def __repr__(self) -> str:
"""Return a string representation of this instance.

Expand Down
Loading