Bug fix: Print Power as str instead of decimal #1232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:microgrid
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a formatting mismatch in the battery manager’s debug log by using %s instead of %d to print Power values.
- Replaced an integer format specifier (
%d) with a string specifier (%s) in a debug log. - Ensured consistent formatting when logging
Powerobjects.
Comments suppressed due to low confidence (1)
src/frequenz/sdk/microgrid/_power_distributing/_component_managers/_battery_manager.py:276
- Ensure that the
Powerclass implements a clear__str__method so that logging with%sproduces a human-readable value rather than the default representation.
"Distributing power %s between the batteries %s",
Commit 41d4543 changed `float` to `Power` in PowerDistributor's battery manager, but left %d in formatting. Signed-off-by: Elzbieta Kotulska <[email protected]>
ela-kotulska-frequenz
force-pushed
the
bug_str
branch
from
5c2b880 to
a01dd8f
Compare
ela-kotulska-frequenz
changed the title
llucax
approved these changes
Jun 11, 2025
github-project-automation
bot
moved this from To do
to Review approved
in Python SDK Roadmap
github-project-automation
bot
moved this from Review approved
to Done
in Python SDK Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 41d4543 changed
floattoPowerin PowerDistributor's battery manager, but left %d in formatting.