-
Notifications
You must be signed in to change notification settings - Fork 20
Improve resampler structure and performance #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1318ce4
tests: Import from public modules when possible
llucax 5eb4655
Split the resampling module
llucax b326d4b
Expose `ResamplingFunction` and `SourceProperties`
llucax 35f4dce
Convert `ResamplingFunction` to a `Protocol`
llucax c8c0f63
pylint: Don't disable check for the whole file
llucax 5503c83
Don't use `Sample` in the resampler buffer and function
llucax 26fa527
Use plain `float`s in the resampler buffer
llucax a8cde98
Replace `average` with `statistics.fmean`
llucax ef8f7bd
benchmark: Move creation of objects out of the hot path
llucax e199b41
Remove `UNIX_EPOCH` and use the one in the core library
llucax b497d17
Use the latest v1 when cross-referencing with channels
llucax d52e73f
Update the microgrid client cross-reference and add client-common
llucax da45456
Fix typo in `ResamplingError` docstring
llucax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure there are no NaNs?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, no
NaNs, noNones,no. That's filtered out before they are fed to the resampling function.infsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry,
infis still allowed:frequenz-sdk-python/src/frequenz/sdk/timeseries/_resampling/_resampler.py
Lines 512 to 514 in c1bc917