Remove obsolete hpack logging adjustment from examples
#1247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: llucax <[email protected]>
Copilot
AI
changed the title
[WIP] Remove obsolete
Remove obsolete hpack logging adjustment from examples/battery_pool.py
Jul 23, 2025
hpack logging adjustment from examples/battery_pool.py
Copilot finished work on behalf of
llucax
July 23, 2025 12:17
There was a problem hiding this comment.
Pull Request Overview
This PR removes obsolete logging configuration for the hpack module from the battery pool example script. The logging adjustment was originally added as a workaround for noise from betterproto, but is no longer needed since the project has moved away from that dependency.
- Removes two lines of hpack-specific logging configuration
- Cleans up obsolete code that could confuse future maintainers
llucax
added
the
cmd:skip-release-notes
llucax
changed the title
hpack logging adjustment from examples/battery_pool.py
llucax
changed the title
hpack logging adjustment from examples/battery_pool.pyhpack logging adjustment from examples
|
Will force-merge as copilot doesn't support gpg signatures yet, so it will never get green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the obsolete logging configuration for
hpackfrom theexamples/battery_pool.pyscript.The following lines were removed:
These lines were originally added as a workaround to reduce noise produced by betterproto, but since the project has moved away from betterproto, they are no longer necessary and serve no purpose.
Benefits:
Fixes #1246.