-
Notifications
You must be signed in to change notification settings - Fork 20
Remove unncessary use of tzdata in tests
#1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a Windows-specific test failure by adding the tzdata package dependency. The issue occurred because zoneinfo requires timezone data that is available by default on Linux but must be installed separately on Windows.
- Adds tzdata package as a Windows-specific dependency for test environments
- Resolves timezone loading issues when running tests on Windows platforms
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Hi @denini08, thanks for submitting a PR! 🙏 I'm not sure what to do about this, I will reply in the issue because there is nothing wrong with the PR itself, but I'm still unsure if we really want to solve this. |
|
Hi, thanks for the follow-up! Tests are failing. Please make sure to run Also ideally squash both commits when things are working again. |
54851f9 to
1ffd5af
Compare
|
@llucax thanks for the feedback, can you please check now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. Just a couple of nitpick comments, but for me this is basically ready to be merged if tests pass.
|
@denini08 we also require all commits to have verified signatures to be able to merge. |
b2131f3 to
e345e81
Compare
|
@llucax can you please check again? |
Signed-off-by: Denini Gabriel <[email protected]>
|
Thanks again for taking the time for this @denini08! I was sort of live-watching as you fixed all the many issue with GPG signing and DCO, I'm sorry the process is so complicated! All seems to be looking good now! Will merge when ready. |
tzdata in tests
|
I took the liberty of updating the PR title to more accurately reflect what it does. |
It's a difficult process, but it was good that I learned some new things |
This PR fixes the issue reported in #1260 where tests failed on Windows because the "Europe/Berlin" timezone could not be loaded.
On Linux, zoneinfo can read timezone data from the system, but on Windows it requires the PyPI tzdata package.