Skip to content

Conversation

@shsms
Copy link
Contributor

@shsms shsms commented Sep 30, 2025

No description provided.

@shsms shsms requested a review from a team as a code owner September 30, 2025 09:36
@shsms shsms requested review from Marenz and Copilot and removed request for a team September 30, 2025 09:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the log level for component status transitions from NOT_WORKING to WORKING state from WARNING to INFO level. This adjustment better reflects that transitioning to a WORKING state is normal operational behavior rather than a warning condition.

  • Changed log level from warning to info for WORKING state transitions
  • Applied the change consistently across PV inverter and EV charger status trackers

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
_pv_inverter_status_tracker.py Updated log level to INFO when PV inverter transitions to WORKING state
_ev_charger_status_tracker.py Updated log level to INFO when EV charger transitions to WORKING state

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the part:microgrid Affects the interactions with the microgrid label Sep 30, 2025
@shsms shsms force-pushed the working-log-levels branch from d89d011 to 8335a3f Compare September 30, 2025 09:37
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms shsms force-pushed the working-log-levels branch from 8335a3f to 5d196b4 Compare September 30, 2025 09:41
@github-actions github-actions bot added the part:docs Affects the documentation label Sep 30, 2025
if self._last_status == ComponentStatusEnum.NOT_WORKING:
_logger.warning(
_logger.info(
"EV charger %s is in WORKING state.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make sense to also say it's becoming functional after being not working? Or at least say "changed state to WORKING` or something like that, saying more explicit it is a state change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@shsms shsms force-pushed the working-log-levels branch from 5d196b4 to 77a0984 Compare October 9, 2025 08:36
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms shsms force-pushed the working-log-levels branch from 77a0984 to f207266 Compare October 9, 2025 08:37
Copy link
Contributor

@Marenz Marenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally hate the release notes update in an extra commit 😆

@github-project-automation github-project-automation bot moved this from To do to Review approved in Python SDK Roadmap Oct 9, 2025
@shsms
Copy link
Contributor Author

shsms commented Oct 9, 2025

Any nasty trick to stay ahead of @llucax: https://github.com/frequenz-floss/frequenz-sdk-python/graphs/contributors \o/

@shsms shsms added this pull request to the merge queue Oct 9, 2025
Merged via the queue into frequenz-floss:v1.x.x with commit 489d50b Oct 9, 2025
5 checks passed
@shsms shsms deleted the working-log-levels branch October 9, 2025 09:21
@github-project-automation github-project-automation bot moved this from Review approved to Done in Python SDK Roadmap Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation part:microgrid Affects the interactions with the microgrid

Projects

Development

Successfully merging this pull request may close these issues.

3 participants