-
Notifications
You must be signed in to change notification settings - Fork 20
Write INFO logs for components transitioning to WORKING state #1277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR changes the log level for component status transitions from NOT_WORKING to WORKING state from WARNING to INFO level. This adjustment better reflects that transitioning to a WORKING state is normal operational behavior rather than a warning condition.
- Changed log level from
warningtoinfofor WORKING state transitions - Applied the change consistently across PV inverter and EV charger status trackers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
_pv_inverter_status_tracker.py |
Updated log level to INFO when PV inverter transitions to WORKING state |
_ev_charger_status_tracker.py |
Updated log level to INFO when EV charger transitions to WORKING state |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
d89d011 to
8335a3f
Compare
Signed-off-by: Sahas Subramanian <[email protected]>
8335a3f to
5d196b4
Compare
| if self._last_status == ComponentStatusEnum.NOT_WORKING: | ||
| _logger.warning( | ||
| _logger.info( | ||
| "EV charger %s is in WORKING state.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make sense to also say it's becoming functional after being not working? Or at least say "changed state to WORKING` or something like that, saying more explicit it is a state change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Sahas Subramanian <[email protected]>
5d196b4 to
77a0984
Compare
Signed-off-by: Sahas Subramanian <[email protected]>
77a0984 to
f207266
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally hate the release notes update in an extra commit 😆
|
Any nasty trick to stay ahead of @llucax: https://github.com/frequenz-floss/frequenz-sdk-python/graphs/contributors \o/ |
No description provided.