Upgrade to repo-config v0.6.1 #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:tests
llucax
force-pushed
the
repo-config-v0.6
branch
3 times, most recently
from
b926787 to
f0a7943
Compare
llucax
added
the
cmd:skip-release-notes
|
OK, this is working and only waiting for the repo-config release. It would be good to merge ASAP so new PRs don't introduce new |
|
Nice side effect: this also speeds up the CI by a minute or two. |
llucax
force-pushed
the
repo-config-v0.6
branch
2 times, most recently
from
56e1c9f to
aefd5d3
Compare
llucax
force-pushed
the
repo-config-v0.6
branch
from
aefd5d3 to
f714e20
Compare
|
Ready for review, updated branch protection rules for the new matrix variable, enabled auto-merge. |
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Now `pydoclint` is used instead. Signed-off-by: Leandro Lucarella <[email protected]>
These are now installed via repo-config. Signed-off-by: Leandro Lucarella <[email protected]>
Now `flake8` is used to check docstrings, so the optional depdendencies should match that. Also add the configuration for `flake8` and the plugins it runs. Signed-off-by: Leandro Lucarella <[email protected]>
Flake8 runs much faster than pylint, so it is preferred. Signed-off-by: Leandro Lucarella <[email protected]>
Adds command-line options and also adds the stub dependencies. Signed-off-by: Leandro Lucarella <[email protected]>
Collected positional and keyword argument should be documented using also the asterisks. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
These imports are used to break circular imports in a very convoluted set of circular dependencies. To do that some types need to be specified as strings and use `typing.TYPE_CHECKING` to conditionally add imports, and it seems like flake8 doesn't detect those strings as types being used. Signed-off-by: Leandro Lucarella <[email protected]>
`microgrid.grid.get()` returns `Grid | None`, so before accessing any attributes from `grid` we need to make sure it is not `None`. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
repo-config-v0.6
branch
from
f714e20 to
65cc73c
Compare
Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
repo-config-v0.6
branch
from
65cc73c to
0aa3c8a
Compare
tiyash-basu-frequenz
previously approved these changes
Sep 4, 2023
src/frequenz/sdk/timeseries/_formula_engine/_formula_generators/_grid_power_formula.py
Show resolved
Hide resolved
src/frequenz/sdk/timeseries/_formula_engine/_formula_generators/_pv_power_formula.py
Outdated
Show resolved
Hide resolved
|
@daniel-zullo-frequenz I just replied to your comments. If it's OK with you please approve so it can be merged. |
daniel-zullo-frequenz
approved these changes
Sep 4, 2023
daniel-zullo-frequenz
previously approved these changes
Sep 4, 2023
Co-authored-by: daniel-zullo-frequenz <[email protected]> Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
repo-config-v0.6
branch
from
1c93bd4 to
5e879be
Compare
daniel-zullo-frequenz
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new repo-config version brings a few important changes:
darglintwithpydoclintflake8basic checksflake8basic checks in tests and benchmarksBecuase of this, this PR is very big, as it needs to fix a lot of issues detected by
pydoclintandflake8.The first commits, up to Add
mypyconfiguration topyproject.tomldeal with the upgrade of repo-config templates.The rest of the commits are documentation fixes (first from
pydoclintand then frompydocstyle) plus some otherflake8fixes, usually in that order.