ci: Fix publishing of documentation on push #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using a literal `true`, yaml will interpret it as a boolean. Signed-off-by: Leandro Lucarella <[email protected]>
If we don't do this, the `publish-docs` will not run on pushes, so the in-development documentation will not be published. While cross-arch tests are generally executed in the merge queue on the identical commit, activating them for push events provides an added layer of security. This is especially important in scenarios where emergency pushes might bypass the merge queue. Signed-off-by: Leandro Lucarella <[email protected]>
github-actions
bot
added
the
part:tooling
llucax
added
cmd:skip-release-notes
tiyash-basu-frequenz
approved these changes
Sep 11, 2023
|
At some point we might check if a job already ran in the merge queue and skip it in the push to save CPU cycles. There is always so much that can be improved in the CI 😱 |
daniel-zullo-frequenz
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
nox-cross-archtest for push events because if we don't do this, thepublish-docswill not run on pushes, so the in-development documentation will not be published.While cross-arch tests are generally executed in the merge queue on the identical commit, activating them for push events provides an added layer of security. This is especially important in scenarios where emergency pushes might bypass the merge queue.