Rename datetime_to_index to to_internal_index #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
cwasicki
force-pushed
the
to_internal
branch
from
f636bf9 to
30b6ee3
Compare
llucax
previously approved these changes
Sep 20, 2023
There was a problem hiding this comment.
LGTM. Approving but tagging @mathias-baumann-frequenz and @Marenz just in case they have something to say.
cwasicki
force-pushed
the
to_internal
branch
from
30b6ee3 to
1ad653f
Compare
cwasicki
force-pushed
the
to_internal
branch
from
1ad653f to
fbdd347
Compare
The method is renamed to avoid confusion between indices in a window, which are passed by the user, and the internal indices that point to the actual position in the internal buffer. Signed-off-by: cwasicki <[email protected]>
cwasicki
force-pushed
the
to_internal
branch
from
fbdd347 to
69ccf70
Compare
|
Rebased on latest v0.x.x, signed and updated release notes (merge with changes from #670). Everything ok from your side @Marenz @matthias-wende-frequenz ? |
Marenz
approved these changes
Sep 20, 2023
matthias-wende-frequenz
approved these changes
Sep 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method is renamed to avoid confusion between indices in a window, which are passed by the user, and the internal indices that point to the actual position in the internal buffer.