Increment port in microgrid API client tests #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the tests a bit more concise and readable. Signed-off-by: Leandro Lucarella <[email protected]>
This helps reducing the boilerplate even further and also makes sure that the server and client ports are the same. Signed-off-by: Leandro Lucarella <[email protected]>
This is a hack to avoid the inherent flakiness of the approach of using a real GRPC (mock) server. The server seems to stay alive for a short time after the test is finished, which causes the next test to fail because the port is already in use. This is a workaround until we have can get rid of the real GRPC server. Signed-off-by: Leandro Lucarella <[email protected]>
github-actions
bot
added
the
part:tests
llucax
added
the
type:tech-debt
|
As I said in the issue, I don't think this really fixes the flakiness reported in #662, but it should still be an improvement in terms of readability and could potentially avoid flakiness on the finalization, so I would merge it anyways. |
|
Enabling auto-merge. |
shsms
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hack to avoid the inherent flakiness of the approach of using a real GRPC (mock) server. The server seems to stay alive for a short time after the test is finished, which causes the next test to fail because the port is already in use.
This also improves the test a bit by using an async context manager create the client and server, and stop the server automatically when the test is finished.
Related to #662.