More updates for n:m support - battery pool's power formula #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:tests
Marenz
force-pushed
the
nminverter
branch
2 times, most recently
from
b4ae13c to
f7d4078
Compare
Marenz
force-pushed
the
nminverter
branch
2 times, most recently
from
0e714d9 to
751463d
Compare
5 tasks
shsms
reviewed
Feb 19, 2024
| component_graph.predecessors(bat_id), | ||
| ) | ||
| ) | ||
| for bat_id in component_ids |
There was a problem hiding this comment.
in a setup with 1 inverter and 2 batteries, there will be 2 frozensets with the same inverter. that would lead to 2x power reporting, no?
There was a problem hiding this comment.
Good catch. Added a test to catch this and fixed it, too
Comment on lines
+97
to
+99
| for idx, comp in enumerate( | ||
| inverter for inverters in battery_inverters for inverter in inverters | ||
| ): |
There was a problem hiding this comment.
maybe the inverter ids can be collected into a set before enumerating, to deduplicate?
Suggested change
| for idx, comp in enumerate( | |
| inverter for inverters in battery_inverters for inverter in inverters | |
| ): | |
| for idx, comp in enumerate( | |
| set(inverter for inverters in battery_inverters for inverter in inverters) | |
| ): |
There was a problem hiding this comment.
I made battery_inverters directly to a frozenset instead
…rters Signed-off-by: Mathias L. Baumann <[email protected]>
shsms
reviewed
Feb 22, 2024
| component_graph = connection_manager.get().component_graph | ||
|
|
||
| battery_inverters = list( | ||
| battery_inverters = frozenset( |
There was a problem hiding this comment.
was this supposed to go into a different commit?
Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
shsms
approved these changes
Feb 22, 2024
shsms
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specifically focuses on the power forumla for the battery pool.
refs #501