Generalize PowerDistributingActor #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is never expected to happen, because the task only reads from channels and writes to channels, and unless there's a bug in the SDK that closes the channels, the task won't die. Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
This just moves the code out, so that it becomes easier to generalize and cleanup. Signed-off-by: Sahas Subramanian <[email protected]>
Also rename the file _distribution_algorithm.py → _battery_distribution_algorithm.py. Signed-off-by: Sahas Subramanian <[email protected]>
github-actions
bot
added
part:docs
|
There might be some reusable code in the |
src/frequenz/sdk/actor/power_distributing/_component_managers/__init__.py
Outdated
Show resolved
Hide resolved
llucax
reviewed
Nov 21, 2023
Comment on lines
-29
to
+31
| succeeded_batteries: set[int] | ||
| """The subset of batteries for which power was set successfully.""" | ||
| succeeded_components: abc.Set[int] | ||
| """The subset of components for which power was set successfully.""" |
There was a problem hiding this comment.
These changes should also go to the upgrading notes, as these types are now read-only.
Signed-off-by: Sahas Subramanian <[email protected]>
shsms
force-pushed
the
power-dist-generic-control
branch
from
253e5f7 to
b9c8573
Compare
Co-authored-by: daniel-zullo-frequenz <[email protected]> Signed-off-by: Sahas Subramanian <[email protected]>
daniel-zullo-frequenz
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the battery-specific logic has been moved into a
BatteryManager(which implementsComponentManager). This includesThis allows us to add
ComponentManagerimplementations for additional component categories, that can be used with the PowerDistributingActor.