Skip to content

Update frequency() to no longer have parameters #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2023
Merged

Update frequency() to no longer have parameters #788

merged 2 commits into from
Dec 6, 2023

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Nov 22, 2023 •
edited
Loading

Changes frequency() to always auto-select the frequency source component

@Marenz Marenz requested a review from a team as a code owner November 22, 2023 15:51
@Marenz Marenz self-assigned this Nov 22, 2023
@github-actions github-actions bot added part:data-pipeline Affects the data pipeline part:microgrid Affects the interactions with the microgrid labels Nov 22, 2023
@Marenz Marenz force-pushed the frequency-component_id branch from 83db46d to 50b73b2 Compare November 22, 2023 15:53
@github-actions github-actions bot added the part:docs Affects the documentation label Nov 22, 2023
@Marenz Marenz force-pushed the frequency-component_id branch from 50b73b2 to cbe664e Compare November 22, 2023 15:56
@Marenz Marenz added this to the v1.0.0-rc4 milestone Nov 22, 2023
llucax

This comment was marked as outdated.

Sign in to view

@Marenz Marenz force-pushed the frequency-component_id branch from cbe664e to a97d460 Compare November 23, 2023 13:23
llucax
llucax reviewed Nov 23, 2023
View reviewed changes
@Marenz Marenz force-pushed the frequency-component_id branch from a97d460 to eab81e0 Compare November 28, 2023 17:13
@Marenz Marenz changed the title Update frequency() to accept int id's Update frequency() to no longer have parameters Nov 28, 2023
@Marenz Marenz force-pushed the frequency-component_id branch from eab81e0 to d7f255c Compare November 28, 2023 17:21
llucax
llucax reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for keep nagging in such a small change, but I think this is really good cleanup, is good that we think a bit more about interfaces as we approach 1.0.

@Marenz Marenz force-pushed the frequency-component_id branch from d7f255c to 3b6f3d7 Compare November 30, 2023 16:36
@Marenz
Remove parameters for frequency()
3da1379 
Signed-off-by: Mathias L. Baumann <[email protected]>
@Marenz
Remove log or make it debug level
8a7c5d3 
Signed-off-by: Mathias L. Baumann <[email protected]>
@Marenz Marenz force-pushed the frequency-component_id branch from 3b6f3d7 to 8a7c5d3 Compare November 30, 2023 16:42
@Marenz Marenz added this pull request to the merge queue Dec 6, 2023
Merged via the queue into frequenz-floss:v1.x.x with commit f89c53b Dec 6, 2023
@Marenz Marenz deleted the frequency-component_id branch December 6, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shsms shsms shsms left review comments

@llucax llucax llucax approved these changes

@matthias-wende-frequenz matthias-wende-frequenz Awaiting requested review from matthias-wende-frequenz matthias-wende-frequenz is a code owner automatically assigned from frequenz-floss/python-sdk-team

Assignees

@Marenz Marenz

Labels

part:data-pipeline Affects the data pipeline part:docs Affects the documentation part:microgrid Affects the interactions with the microgrid

Projects

Python SDK Roadmap
Status: Done

Milestone

v1.0.0-rc4

Development

Successfully merging this pull request may close these issues.

3 participants

@Marenz @llucax @shsms