Some component status cleanup #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's going to be status trackers for more component types. Those can now go into the `_component_status` package. Signed-off-by: Sahas Subramanian <[email protected]>
When constructing `ComponentPoolStatusTracker` objects. Signed-off-by: Sahas Subramanian <[email protected]>
In the component status tracking parts of the power distributor. Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
github-actions
bot
added
part:tests
|
Only internal improvements, no release notes necessary. |
shsms
added
the
cmd:skip-release-notes
shsms
force-pushed
the
component-status
branch
from
d0d6867 to
97e59b7
Compare
llucax
approved these changes
Jan 16, 2024
llucax
added
the
type:tech-debt
no, but they do allocate in the hot path, which is many times slower than referencing a cached value. |
|
Yeah, creating objects is really slow. Not sure if there will be any caching going on when creating the same (immutable) object over and over though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timedeltas instead offloats for duration in component status trackers.ComponentStatusTrackers intoBackgroundServices