Improve BatteryPool's SoC accuracy at the edges #843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shsms
added
the
cmd:skip-release-notes
llucax
previously approved these changes
Jan 15, 2024
| if timestamp == _MIN_TIMESTAMP: | ||
| return Sample(datetime.now(tz=timezone.utc), None) | ||
|
|
||
| pct = 0.0 |
There was a problem hiding this comment.
I would add a comment about the intention of pct being literally 0.0 and 100.0 on the edges, just in case anyone feels tempted to simplify the code.
Signed-off-by: Sahas Subramanian <[email protected]>
This helps better leverage the new instruction specialization feature of Python. Signed-off-by: Sahas Subramanian <[email protected]>
shsms
force-pushed
the
full-battery-soc
branch
from
789daf4 to
3c17ac3
Compare
llucax
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SoC is close to 0.0 or 100.0, it will be exactly 0.0 or 100.0.