Drop old propsals from the PowerManager #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the PowerManager receives a `PartialFailure`, in many cases, resending the request would fix it, because the power distributor would have new information on how to redistribute differently. But this doesn't always work, for example in single battery locations or if all batteries are in an UNCERTAIN state, in which case the power distributor has to retry with the same batteries. For this reason, if we don't have a limit on such retries from the PowerManager, we'd get into an infinite loop that doesn't have any delay inbetween retries. Signed-off-by: Sahas Subramanian <[email protected]>
This is used to identify proposals that are too old, so that they can be removed from consideration when the PowerManager calculates target power. Signed-off-by: Sahas Subramanian <[email protected]>
github-actions
bot
added
part:tests
shsms
force-pushed
the
power-manager-improvements
branch
from
34a5bdc to
de2f993
Compare
|
@daniel-zullo-frequenz I think this needs to be done before we can deploy the power manager. |
daniel-zullo-frequenz
previously approved these changes
Jan 19, 2024
In the matryoshka algorithm, this method is implemented to delete proposals that haven't been replaced/updated in the last `max_proposal_age`. Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
shsms
force-pushed
the
power-manager-improvements
branch
from
de2f993 to
ce586b0
Compare
|
Fixed a small bug that would have triggered when using multiple battery pools with different batteries in the same location. |
daniel-zullo-frequenz
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PowerManager doesn't have a way to identify if an actor that sent a proposal is still active. It needs to know that to know when to drop proposals from a given sender.
With this PR, the resending of proposals by actors also functions as a heart-beat between the actors and the power manager. If an actor hasn't sent a new proposal in 60 seconds, the latest available proposal from that actor is also removed from the power manager.