Allow all quantities division by float | Self
#876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
|
Based on: |
Marenz
reviewed
Feb 13, 2024
Marenz
reviewed
Feb 13, 2024
Marenz
reviewed
Feb 13, 2024
Marenz
reviewed
Feb 13, 2024
Marenz
reviewed
Feb 13, 2024
Isn't this a paradox? |
|
Thanks for the review, I will update once #875 is merged. |
llucax
force-pushed
the
quantity-div-float
branch
from
4ba665c to
656f88b
Compare
|
Rebased and marked the PR ready for review. You comments should be already addressed. |
|
Enabling auto-merge as this had a previous review already. |
shsms
reviewed
Feb 16, 2024
llucax
force-pushed
the
quantity-div-float
branch
from
656f88b to
58ae589
Compare
llucax
changed the title
float | Percentage | Selffloat | Self
|
Updated to remove division by |
shsms
reviewed
Feb 16, 2024
llucax
force-pushed
the
quantity-div-float
branch
from
58ae589 to
375d71d
Compare
Dividing by `float` is only applying a factor so it should be safe for any `Quantity`. Dividing by `Self` produces a unit-less ration (`float`), so it should be safe too. To be able to use nicer names in overloads, we use positional-only arguments for `__truediv__()`, which in practice shouldn't be much of a breaking change as these methods should be used mostly via operators. We also use `match` syntax in the changed methods. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
quantity-div-float
branch
from
375d71d to
15ac8c8
Compare
|
Updated to hopefully remove all the remaining mentions to percentage and rebased. |
|
ping @shsms |
shsms
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dividing by
floatis only applying a factor so it should be safe for anyQuantity.Dividing by
Selfproduces a unit-less ration (float), so it should be safe too.To be able to use nicer names in overloads, we use positional-only arguments for
__truediv__(), which in practice shouldn't be much of a breaking change as these methods should be used mostly via operators.We also use
matchsyntax in the changed methods.