Remove unnecessary send adapter #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous versions of the `channels` library, the `send()` method returned `bool` to indicate if the send was succesful or not. Recent versions use exception to report errors and return `None`, making the `send()` method directly compatible with what the resampler expects, so we don't need an adapter any more. Signed-off-by: Leandro Lucarella <[email protected]>
github-actions
bot
added
the
part:actor
llucax
added
the
cmd:skip-release-notes
llucax
added
the
type:tech-debt
|
Enabled auto-merge. |
daniel-zullo-frequenz
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous versions of the
channelslibrary, thesend()method returnedboolto indicate if the send was succesful or not. Recent versions use exception to report errors and returnNone, making thesend()method directly compatible with what the resampler expects, so we don't need an adapter any more.