Skip to content

Add a PVPool implementation #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Apr 10, 2024
Merged

Add a PVPool implementation #914

merged 23 commits into from
Apr 10, 2024

Conversation

@shsms
Copy link
Contributor

@shsms shsms commented Apr 4, 2024

No description provided.

@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:data-pipeline Affects the data pipeline part:actor Affects an actor ot the actors utilities (decorator, etc.) part:core Affects the SDK core components (data structures, etc.) part:microgrid Affects the interactions with the microgrid labels Apr 4, 2024
@shsms shsms added this to the v1.0.0-rc6 milestone Apr 5, 2024
@shsms shsms force-pushed the pv-pool branch 2 times, most recently from 6cb9030 to 7f4e115 Compare April 5, 2024 16:58
@shsms shsms marked this pull request as ready for review April 8, 2024 09:45
@shsms shsms requested a review from a team as a code owner April 8, 2024 09:45
@llucax
Copy link
Contributor

llucax commented Apr 9, 2024

CI is failing, I'm starting a review anyway, so please unless it is very small and trivial stuff (or adding more commits to amend later), please don't update the PR.

@github-actions github-actions bot added the part:docs Affects the documentation label Apr 9, 2024
@shsms
Copy link
Contributor Author

shsms commented Apr 9, 2024

Added a few commits including tests, docu updates, release notes and a fixup for a bugfix.

llucax
llucax reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, very nice job and it is really nice to see al this finally coming together! 💯

@shsms
Copy link
Contributor Author

shsms commented Apr 10, 2024

I've squashed the old fixups, will address the comments in new fixups.

@shsms shsms mentioned this pull request Apr 10, 2024
Open
@shsms shsms requested a review from llucax April 10, 2024 08:25
@shsms
Copy link
Contributor Author

shsms commented Apr 10, 2024

I will squash the commits around 3pm.

@llucax llucax mentioned this pull request Apr 10, 2024
Open
llucax
llucax previously approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve to speed up things, but I'm still concerned about #914 (comment), if we are not logging unexpected errors in other pools too, we can create a separate issue to fix this, but I think silently swallowing exceptions should never happen.

@shsms shsms force-pushed the pv-pool branch 2 times, most recently from 625378b to faecdbf Compare April 10, 2024 12:24
llucax
llucax reviewed Apr 10, 2024
View reviewed changes
shsms and others added 17 commits April 10, 2024 15:57
@shsms
Implement a SystemBoundsTracker for PV inverters
6633e9a 
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Implement a PV pool with a _system_power_bounds method
446187b 
These system bounds trackers need to be moved out of the `*Pool`s, but
exactly how, is yet to be decided.  Until then, I'm following the same
pattern here as in the other `*Pool`s.

This commit adds a `_system_power_bounds` method only because that's
all that's needed for the PowerManager to support PV inverters.

Other methods will be added later.

Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Expose the PVPool through microgrid.pv_pool()
d1021d3 
There is a plan to rename these constructors to
`microgrid.new_*_pool()`.  Not doing that now, so that it can be done
together for all the pools in a separate PR.

Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Support PV inverters in the PowerManager
5d62396 
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Implement power_status reporting from the PV pool
bb333e0 
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Support sending power proposals to PowerManager from the PVPool
f091eaf 
This is done through the new `PVPool.propose_power` method.

This commit also adds a `component_ids` property, that exposes the IDs
of the PV inverters managed by this PVPool.

Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Move the PV power formula from logical_meter to PVPool
141f896 
Also update the PV formula builder to use the component IDs from the
PV pool if specified.

Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Add a stop method to BatteryPool
a039724 
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Add tests for PVPool control methods
5093900 
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Add section for PV arrays in microgrid concepts documentation
79a725c 
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Update section for EV chargers in microgrid concepts documentation
c647ed0 
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Update release notes
0411b7d 
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Make component_category and component_type parameters kw-only
09c8414 
This affects the PowerManager, PowerDistributor and PowerWrapper.  The
`component_type` paramater now also has a default value of `None`.

Signed-off-by: Sahas Subramanian <[email protected]>
@shsms @llucax
Initialize super-class as the first step
0f022ab 
Co-authored-by: Leandro Lucarella <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms @llucax
Fix docstring
22158fe 
Co-authored-by: Leandro Lucarella <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Broaden exception handling when setting power through microgrid API
4f9883d 
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Remove *Pool constructor related docs from the class docs
30f19c0 
Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Fix exception handling bugs in EV and PV managers
6e1400d 
Also use `logging.exception` to log broad exceptions

Signed-off-by: Sahas Subramanian <[email protected]>
@shsms
Copy link
Contributor Author

shsms commented Apr 10, 2024

I added all the exception related fixes to the latest commit.

@shsms shsms requested a review from llucax April 10, 2024 14:15
@shsms
Copy link
Contributor Author

shsms commented Apr 10, 2024

Also squashed the commits.

@shsms
Copy link
Contributor Author

shsms commented Apr 10, 2024

Enabling auto-merge

@shsms shsms enabled auto-merge April 10, 2024 15:01
llucax
llucax approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉

@shsms shsms added this pull request to the merge queue Apr 10, 2024
Merged via the queue into frequenz-floss:v1.x.x with commit be82217 Apr 10, 2024
@shsms shsms deleted the pv-pool branch April 10, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llucax llucax llucax approved these changes

@daniel-zullo-frequenz daniel-zullo-frequenz Awaiting requested review from daniel-zullo-frequenz daniel-zullo-frequenz is a code owner automatically assigned from frequenz-floss/python-sdk-team

Assignees

@shsms shsms

Labels

part:actor Affects an actor ot the actors utilities (decorator, etc.) part:core Affects the SDK core components (data structures, etc.) part:data-pipeline Affects the data pipeline part:docs Affects the documentation part:microgrid Affects the interactions with the microgrid part:tests Affects the unit, integration and performance (benchmarks) tests

Projects

Python SDK Roadmap
Status: Done

Milestone

v1.0.0-rc6

Development

Successfully merging this pull request may close these issues.

2 participants

@shsms @llucax