Some EV charger pool cleanup and fixes #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
The EV charger manager has its own task that tracks the status of the EV chargers and redistributes power to them as EVs are connected and disconnected. This approach is specific to the EV charger pool, because the status of the components is dynamic, unlike the BatteryPool and the PVPool. This task needs to run only in locations where there are EV chargers, because it expects that there be at least one EV charger in a location and runs into issues if that's not the case. Signed-off-by: Sahas Subramanian <[email protected]>
The API would reset power back to 0 after an interval only for batteries. For EV chargers and PV inverters, it will not have a reset mechanism. Signed-off-by: Sahas Subramanian <[email protected]>
github-actions
bot
added
part:tests
shsms
added
the
cmd:skip-release-notes
|
Skip release notes because these are internal changes and bugfixes to unreleased features. |
llucax
approved these changes
Apr 8, 2024
It is just that this is where we already have the list of available component IDs. Otherwise, we'd have to get the component IDs for all component types in the Also, they are lazily started, so an EVChargerManager or even a PowerDistributor instance is only started when a corresponding call is made to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.