Skip to content

Filter out irrelevant logs when checking for expected logs #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Filter out irrelevant logs when checking for expected logs #983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions tests/actor/test_actor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,9 @@ async def test_restart_on_unhandled_exception(
restart_limit: The restart limit to use.
caplog: The log capture fixture.
"""
caplog.set_level("DEBUG", logger="frequenz.sdk.actor._actor")
caplog.set_level("DEBUG", logger="frequenz.sdk.actor._run_utils")
relevant_loggers = {"frequenz.sdk.actor._actor", "frequenz.sdk.actor._run_utils"}
for logger in relevant_loggers:
caplog.set_level("DEBUG", logger=logger)

channel: Broadcast[int] = Broadcast(name="channel")

Expand Down Expand Up @@ -270,9 +271,14 @@ async def test_restart_on_unhandled_exception(
(*RUN_INFO, "All 1 actor(s) finished."),
]
)
print("expected_log:", expected_log)
print("caplog.record_tuples:", caplog.record_tuples)
assert caplog.record_tuples == expected_log
# This is an ugly hack. There seem to be some issues with asyncio and caplog, maybe
# pytest-asyncio, that reports some pending tasks from an unrelated test when tested
# inside QEMU (suggesting also some timing issue when things run very slow).
filtered_logs = [r for r in caplog.record_tuples if r[0] in relevant_loggers]
print("filtered_logs:", filtered_logs)
print("expected_log:", expected_log)
assert filtered_logs == expected_log


async def test_does_not_restart_on_normal_exit(
Expand Down