Skip to content

UI bug slideswitch fix #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kghs-aver wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

UI bug slideswitch fix #562

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3e22b5
fix slideswitch misplaced bug
kghs-aver Mar 23, 2025
1f84513
fix the ui bug where the slideswitch get detached from the wires
kghs-aver Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ArduinoFrontend/src/app/Libs/inputs/Buttons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ export class SlideSwitch extends CircuitElement {
*/
constructor(public canvas: any, x: number, y: number) {
super('SlideSwitch', x, y, 'SlideSwitch.json', canvas);
this.setDragListeners();
}
/**
* Initialize Slide Switch
Expand Down Expand Up @@ -283,6 +284,7 @@ export class SlideSwitch extends CircuitElement {
*/
closeSimulation(): void {
this.elements.unclick();
this.elements.undrag();
this.setDragListeners();
this.setClickListener(null);
const anim = Raphael.animation({ transform: `t${this.tx},${this.ty}` }, 500);
Expand Down