Skip to content

Add no-GIL support #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clin1234 wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add no-GIL support #267

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
37ca658
Disable building for limited API with no-GIL interpreters
clin1234 Sep 10, 2025
c9d437c
Update setup.py
clin1234 Sep 10, 2025
f1235f4
Fix minor oops
clin1234 Sep 10, 2025
a210958
FIx minor oops
clin1234 Sep 10, 2025
6285cec
Another try
clin1234 Sep 10, 2025
1969b49
Delete setup.cfg
clin1234 Sep 10, 2025
8b9ece6
Call PyUnstable_Module_SetGIL
clin1234 Sep 10, 2025
4842cb3
Do not build extension.c with limited API
clin1234 Sep 10, 2025
ec21403
Extremely silly spelling fix
clin1234 Sep 10, 2025
e2ef84d
Update frida/_frida/extension.c
clin1234 Nov 4, 2025
449688e
Restore building extension with limited API for now
clin1234 Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions frida/_frida/extension.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6018,6 +6018,10 @@ PyInit__frida (void)

module = PyModule_Create (&PyFrida_moduledef);

#ifdef Py_GIL_DISABLED
PyUnstable_Module_SetGIL(module, Py_MOD_GIL_NOT_USED);
#endif

PyModule_AddStringConstant (module, "__version__", frida_version_string ());

PYFRIDA_REGISTER_TYPE (GObject, G_TYPE_OBJECT);
Expand Down
1 change: 0 additions & 1 deletion frida/_frida/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ elif host_os_family != 'windows'
endif

extension = python.extension_module('_frida', 'extension.c',
limited_api: '3.7',
Copy link
Member

@oleavr oleavr Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a regression, unless I'm missing something?

Copy link
Author

@clin1234 clin1234 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you ask, maybe that is no longer needed?

Copy link
Member

@oleavr oleavr Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason we have it is so we can build a single binary (per OS/ABI combo) that works on older Python runtimes even when the build machine has a newer Python; without accidentally regressing on the range of versions supported.

Copy link
Author

@clin1234 clin1234 Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason we have it is so we can build a single binary (per OS/ABI combo) that works on older Python runtimes even when the build machine has a newer Python; without accidentally regressing on the range of versions supported.

Just to be sure, can you run workflows on your side to catch whatever regression that may arise from this PR?

Copy link
Member

@oleavr oleavr Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no point; I went through some pain to transition frida-python to the limited API, because it solved some long-standing issues. Nothing changed there. We cannot drop this.

Copy link
Author

@clin1234 clin1234 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough: https://peps.python.org/pep-0803/ means that free-threaded wheels will have stable ABI starting in 3.15...

c_args: frida_component_cflags,
link_args: extra_link_args,
dependencies: [python_dep, frida_core_dep, os_deps],
Expand Down
2 changes: 0 additions & 2 deletions setup.cfg
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import shutil
import subprocess
import sys
import sysconfig
from pathlib import Path
from typing import Iterator

Expand All @@ -13,7 +14,6 @@
SOURCE_ROOT = Path(__file__).resolve().parent
FRIDA_EXTENSION = os.environ.get("FRIDA_EXTENSION", None)


def main():
setup(
name="frida",
Expand All @@ -24,7 +24,7 @@ def main():
author="Frida Developers",
author_email="oleavr@frida.re",
url="https://frida.re",
install_requires=["typing_extensions; python_version<'3.11'"],
install_requires=["typing_extensions"],
python_requires=">=3.7",
license="wxWindows Library Licence, Version 3.1",
keywords="frida debugger dynamic instrumentation inject javascript windows macos linux ios iphone ipad android qnx",
Expand Down Expand Up @@ -56,7 +56,7 @@ def main():
Extension(
name="frida._frida",
sources=["frida/_frida/extension.c"],
py_limited_api=True,
py_limited_api=not(bool(sysconfig.get_config_var("Py_GIL_DISABLED"))),
)
],
cmdclass={"build_ext": FridaPrebuiltExt if FRIDA_EXTENSION is not None else FridaDemandBuiltExt},
Expand Down