Don't refer to files that doesn't exist anymore#106
Open
challet wants to merge 1 commit intofroala:masterfrom
Open
Don't refer to files that doesn't exist anymore#106challet wants to merge 1 commit intofroala:masterfrom
challet wants to merge 1 commit intofroala:masterfrom
Conversation
Version 4.0.4 deleted these files but they were still refered to in _media function
Author
|
That breaks Django ManifestStaticFilesStorage in production. Not only the request going to the static file, but the page refering to it, since it tries to inject an md5 hash from a file that doesn't exist. |
challet
changed the title
thomphil
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 4.0.4 deleted these files but they were still refered to in
_mediafunction.Strangely looks like this bug from 2017 : #43